Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap the order of Model Registry and Model Serving in left navigation #3171

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Swap the order of Model Registry and Model Serving in left navigation #3171

merged 1 commit into from
Sep 10, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Sep 9, 2024

Closes: RHOAIENG-12253

Description

This PR aims to show the Model Registry above the Model Serving in left navigation.
Screenshot 2024-09-09 at 8 51 27 PM

How Has This Been Tested?

  1. Run npm run start:dev:ext in the frontend and see that the Model Registry is above the Model Serving.

Test Impact

NA

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (d89ab8d) to head (e3dcbe2).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3171      +/-   ##
==========================================
- Coverage   85.27%   85.27%   -0.01%     
==========================================
  Files        1258     1258              
  Lines       27689    27689              
  Branches     7372     7372              
==========================================
- Hits        23612    23611       -1     
- Misses       4077     4078       +1
Files with missing lines Coverage Δ
frontend/src/utilities/NavData.tsx 98.03% <ø> (ø)

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89ab8d...e3dcbe2. Read the comment docs.

manaswinidas
manaswinidas approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@manaswinidas manaswinidas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Model Registry appears above Model Serving

Screenshot 2024-09-10 at 3 01 23 PM

@openshift-ci openshift-ci bot added the lgtm label Sep 10, 2024
mturley
mturley approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1785e82 into opendatahub-io:main Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturley mturley mturley approved these changes

@manaswinidas manaswinidas manaswinidas approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@Gkrumbach07 Gkrumbach07 Awaiting requested review from Gkrumbach07

Assignees

@mturley mturley

@manaswinidas manaswinidas

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppadti @mturley @manaswinidas